Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds a commit message checker, which should fail on this commit … #18

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Mar 27, 2024

…subject too long

Change-Id: I47d33b272fff7d93838560ee5e1225b26c956a15


This change is Reviewable

@jasonleenaylor jasonleenaylor force-pushed the feature/addCommitMessageCheck branch 13 times, most recently from 1e4c0fb to 1921485 Compare March 28, 2024 17:31

This comment has been minimized.

@jasonleenaylor jasonleenaylor force-pushed the feature/addCommitMessageCheck branch 16 times, most recently from 23cdc77 to f19a498 Compare March 28, 2024 21:07
@jasonleenaylor jasonleenaylor force-pushed the feature/addCommitMessageCheck branch 10 times, most recently from fcbe167 to 2169f1a Compare March 28, 2024 22:34
@jasonleenaylor jasonleenaylor marked this pull request as ready for review March 28, 2024 22:35
@jasonleenaylor jasonleenaylor force-pushed the feature/addCommitMessageCheck branch 2 times, most recently from 7792c0b to bd0b4a9 Compare March 28, 2024 22:49
Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@jasonleenaylor jasonleenaylor merged commit 3a4f3ba into release/9.1 Apr 2, 2024
4 of 5 checks passed
@jasonleenaylor jasonleenaylor deleted the feature/addCommitMessageCheck branch April 2, 2024 15:46
jasonleenaylor added a commit to sillsdev/TheCombine that referenced this pull request Apr 2, 2024
* This lints all the commit comments in a PR and reports on any that
  do not match the linting rules
* It adds a pretty comment to the PR if there are any issues found
jasonleenaylor added a commit to sillsdev/TheCombine that referenced this pull request Apr 3, 2024
* This lints all the commit comments in a PR and reports on any that
  do not match the linting rules
* It adds a pretty comment to the PR if there are any issues found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants